Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Assets install rule to Distance #1463

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Californ1a
Copy link

One of the most widely-used mods for Distance is the Custom Car mod, adding the ability to use custom car models which are all made by different authors and historically managed in this repo.

With Distance being added to Thunderstore, we'd like individual car model authors to be able to publish their cars there as separate packages users can install individually, but each car isn't a mod itself, just a Unity asset file, and previously, pre-Thunderstore, they would all be placed within an Assets folder inside the core mod's plugin folder (..\BepInEx\plugins\CustomCar\Assets\<any structure>\CarFile with ..\BepInEx\plugins\CustomCar\CustomCar.dll). However, that structure, putting assets inside the folder of a different plugin, doesn't seem to be possible with r2's install rules. So this PR change would allow us to use a top-level Assets folder (..\BepInEx\Assets\) similar to GTFO (as per the "Structuring your Thunderstore package" wiki page), and we can update our core custom car mod to read from both locations.

If there is a way to structure the individual car asset packages such that they would get installed to ..\BepInEx\plugins\<team>-CustomCar\Assets\<car author>\CarFile or similar without this PR and us having to update our existing core mod, please let me know.

There is also already a PR open to add a Cars section to Thunderstore where these custom car assets will be listed: thunderstore-io/ecosystem-schema#74
And if this change also needs to be made separately somewhere for the Thunderstore App, I couldn't find where to do that.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants